1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
|
# TODO: Temporarily disabled due to importing old code into openshift-ansible
# repo. We will work on these over time.
# pylint: disable=bad-continuation,missing-docstring,no-self-use,invalid-name
import os
import unittest
import tempfile
import shutil
import yaml
from six.moves import cStringIO
from ooinstall.oo_config import OOConfig, Host, OOConfigInvalidHostError
import ooinstall.openshift_ansible
SAMPLE_CONFIG = """
variant: openshift-enterprise
variant_version: 3.3
version: v2
deployment:
ansible_ssh_user: root
hosts:
- connect_to: master-private.example.com
ip: 10.0.0.1
hostname: master-private.example.com
public_ip: 24.222.0.1
public_hostname: master.example.com
roles:
- master
- node
- connect_to: node1-private.example.com
ip: 10.0.0.2
hostname: node1-private.example.com
public_ip: 24.222.0.2
public_hostname: node1.example.com
roles:
- node
- connect_to: node2-private.example.com
ip: 10.0.0.3
hostname: node2-private.example.com
public_ip: 24.222.0.3
public_hostname: node2.example.com
roles:
- node
roles:
master:
node:
"""
CONFIG_INCOMPLETE_FACTS = """
version: v2
deployment:
ansible_ssh_user: root
hosts:
- connect_to: 10.0.0.1
ip: 10.0.0.1
hostname: master-private.example.com
public_ip: 24.222.0.1
public_hostname: master.example.com
roles:
- master
- connect_to: 10.0.0.2
ip: 10.0.0.2
hostname: 24.222.0.2
public_ip: 24.222.0.2
roles:
- node
- connect_to: 10.0.0.3
ip: 10.0.0.3
roles:
- node
roles:
master:
node:
"""
CONFIG_BAD = """
variant: openshift-enterprise
version: v2
deployment:
ansible_ssh_user: root
hosts:
- connect_to: master-private.example.com
ip: 10.0.0.1
hostname: master-private.example.com
public_ip: 24.222.0.1
public_hostname: master.example.com
roles:
- master
- node
- ip: 10.0.0.2
hostname: node1-private.example.com
public_ip: 24.222.0.2
public_hostname: node1.example.com
roles:
- node
- connect_to: node2-private.example.com
ip: 10.0.0.3
hostname: node2-private.example.com
public_ip: 24.222.0.3
public_hostname: node2.example.com
roles:
- node
roles:
master:
node:
"""
class OOInstallFixture(unittest.TestCase):
def setUp(self):
self.tempfiles = []
self.work_dir = tempfile.mkdtemp(prefix='ooconfigtests')
self.tempfiles.append(self.work_dir)
def tearDown(self):
for path in self.tempfiles:
if os.path.isdir(path):
shutil.rmtree(path)
else:
os.remove(path)
def write_config(self, path, config_str):
"""
Write given config to a temporary file which will be cleaned
up in teardown.
Returns full path to the file.
"""
cfg_file = open(path, 'w')
cfg_file.write(config_str)
cfg_file.close()
return path
class OOConfigTests(OOInstallFixture):
def test_load_config(self):
cfg_path = self.write_config(
os.path.join(self.work_dir, 'ooinstall.conf'), SAMPLE_CONFIG)
ooconfig = OOConfig(cfg_path)
self.assertEquals(3, len(ooconfig.deployment.hosts))
self.assertEquals("master-private.example.com", ooconfig.deployment.hosts[0].connect_to)
self.assertEquals("10.0.0.1", ooconfig.deployment.hosts[0].ip)
self.assertEquals("master-private.example.com", ooconfig.deployment.hosts[0].hostname)
self.assertEquals(["10.0.0.1", "10.0.0.2", "10.0.0.3"],
[host.ip for host in ooconfig.deployment.hosts])
self.assertEquals('openshift-enterprise', ooconfig.settings['variant'])
self.assertEquals('v2', ooconfig.settings['version'])
def test_load_bad_config(self):
cfg_path = self.write_config(
os.path.join(self.work_dir, 'ooinstall.conf'), CONFIG_BAD)
try:
OOConfig(cfg_path)
assert False
except OOConfigInvalidHostError:
assert True
def test_load_complete_facts(self):
cfg_path = self.write_config(
os.path.join(self.work_dir, 'ooinstall.conf'), SAMPLE_CONFIG)
ooconfig = OOConfig(cfg_path)
missing_host_facts = ooconfig.calc_missing_facts()
self.assertEquals(0, len(missing_host_facts))
# Test missing optional facts the user must confirm:
def test_load_host_incomplete_facts(self):
cfg_path = self.write_config(
os.path.join(self.work_dir, 'ooinstall.conf'), CONFIG_INCOMPLETE_FACTS)
ooconfig = OOConfig(cfg_path)
missing_host_facts = ooconfig.calc_missing_facts()
self.assertEquals(2, len(missing_host_facts))
self.assertEquals(1, len(missing_host_facts['10.0.0.2']))
self.assertEquals(3, len(missing_host_facts['10.0.0.3']))
def test_write_config(self):
cfg_path = self.write_config(
os.path.join(self.work_dir, 'ooinstall.conf'), SAMPLE_CONFIG)
ooconfig = OOConfig(cfg_path)
ooconfig.save_to_disk()
f = open(cfg_path, 'r')
written_config = yaml.safe_load(f.read())
f.close()
self.assertEquals(3, len(written_config['deployment']['hosts']))
for h in written_config['deployment']['hosts']:
self.assertTrue('ip' in h)
self.assertTrue('public_ip' in h)
self.assertTrue('hostname' in h)
self.assertTrue('public_hostname' in h)
self.assertTrue('ansible_ssh_user' in written_config['deployment'])
self.assertTrue('variant' in written_config)
self.assertEquals('v2', written_config['version'])
# Some advanced settings should not get written out if they
# were not specified by the user:
self.assertFalse('ansible_inventory_directory' in written_config)
class HostTests(OOInstallFixture):
def test_load_host_no_ip_or_hostname(self):
yaml_props = {
'public_ip': '192.168.0.1',
'public_hostname': 'a.example.com',
'master': True
}
self.assertRaises(OOConfigInvalidHostError, Host, **yaml_props)
def test_load_host_no_master_or_node_specified(self):
yaml_props = {
'ip': '192.168.0.1',
'hostname': 'a.example.com',
'public_ip': '192.168.0.1',
'public_hostname': 'a.example.com',
}
self.assertRaises(OOConfigInvalidHostError, Host, **yaml_props)
def test_inventory_file_quotes_node_labels(self):
"""Verify a host entry wraps openshift_node_labels value in double quotes"""
yaml_props = {
'ip': '192.168.0.1',
'hostname': 'a.example.com',
'connect_to': 'a-private.example.com',
'public_ip': '192.168.0.1',
'public_hostname': 'a.example.com',
'new_host': True,
'roles': ['node'],
'node_labels': {
'region': 'infra'
},
}
new_node = Host(**yaml_props)
inventory = cStringIO()
# This is what the 'write_host' function generates. write_host
# has no return value, it just writes directly to the file
# 'inventory' which in this test-case is a StringIO object
ooinstall.openshift_ansible.write_host(
new_node,
'node',
inventory,
schedulable=True)
# read the value of what was written to the inventory "file"
legacy_inventory_line = inventory.getvalue()
# Given the `yaml_props` above we should see a line like this:
# openshift_node_labels="{'region': 'infra'}"
# Quotes around the hash
node_labels_expected = '''openshift_node_labels="{'region': 'infra'}"'''
# No quotes around the hash
node_labels_bad = '''openshift_node_labels={'region': 'infra'}'''
# The good line is present in the written inventory line
self.assertIn(node_labels_expected, legacy_inventory_line)
# An unquoted version is not present
self.assertNotIn(node_labels_bad, legacy_inventory_line)
|
