csa/devops/ansible-patches/openshift.git/roles/openshift_health_checker/action_plugins, branch ands

Ensure proper variable templating for skopeo auth credentials

2017-10-17T19:15:14+00:00

Currently, docker_image_availability.py plugin check is
using the raw strings for variables from task_vars.

This results in any variables that utilized within the
plugin to be un-templated.  For instance, if variable
"x" is set to "{{ y }}" and y is set to "2", one
would expect that x == 2 inside the plugin.  Currently,
the plugin will use the string "{{ y }}" for the value
of x instead of templating the variable.

This commit ensures skopeo registry auth credentials
are templated properly.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1500698

openshift_checks: enable providing file outputs

2017-09-18T21:04:39+00:00

Some refactoring of checks and the action plugin to enable writing files
locally about the check operation and results, if the user wants them.
This is aimed at enabling persistent and machine-readable results from
recurring runs of health checks.

Now, rather than trying to build a result hash to return from running
each check, checks can just register what they need to as they're going
along, and the action plugin processes state when the check is done.
Checks can register failures, notes about what they saw, and arbitrary
files to be saved into a directory structure where the user specifies.
If no directory is specified, no files are written.

At this time checks can still return a result hash, but that will likely
be refactored away in the next iteration.

Multiple failures can be registered without halting check execution.
Throwing an exception or returning a hash with "failed" is registered as
a failure.

execute_module now does a little more with the results. Results are
automatically included in notes and written individually as files.
"changed" results are propagated. Some json results are decoded.

A few of the checks were enhanced to use these features; all get some of
the features for free.

openshift_health_check: allow disabling all checks

2017-09-12T14:32:43+00:00

Can now set openshift_disable_check=* to disable all checks without
needing to know their names.

fixes bug 1462106
https://bugzilla.redhat.com/show_bug.cgi?id=1462106

Update error message: s/non-unique/duplicate

2017-08-24T13:00:34+00:00

Make pylint disables more specific

2017-08-24T13:00:30+00:00

And beautify the code a bit.

Handle more exceptions when running checks

2017-08-24T13:00:16+00:00

This prevents an exception in one check from interfering with other
checks. Skips checks that raise an exception in their is_active method.

Whenever capturing a broad exception in the `is_action` or `run`
methods, include traceback information that can be useful in bug
reports.

List known checks/tags when check name is invalid

2017-08-24T13:00:12+00:00

List existing health checks when none is requested

2017-08-24T12:59:50+00:00

This is a simple mechanism to learn what health checks are available.

Note that we defer task_vars verification, so that we can compute
requested_checks and resolved_checks earlier, allowing us to list checks
even if openshift_facts has not run.

openshift_checks: add property to track 'changed'

2017-08-02T18:06:37+00:00

Introduced the 'changed' property for checks that can make changes to
track whether they did or not. Rather than the check's own logic having
to track this and include it in the result hash, just set the property
and have the action plugin insert it in the result hash after running
(even if there is an exception).

Cleared out a lot of crufty "changed: false" hash entries.

Normalize list of checks passed to action plugin

2017-07-27T14:30:19+00:00

This allows users to pass either a string with comma-separated check
names or a proper list of strings, whatever is more convenient in the
context.

For consistency, the same normalization is applied to the
'openshift_disable_check' variable.