Currently, docker_upgrade is ignored during
cluster upgrades.

This commit ensures that the variable is respected.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1543714

In some setups, system containers may be used
in conjunction with package_docker.

This commit ensures that the atomic
proxies are configured while using package_docker
and containerized components.

This commit also ensures containerized_groups
are based on openshift_is_containerized instead
of 'containerized' variable directly to
account for possible use of atomic hosts which
users may not specify containerized in inventory
directly.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535323

Automatic merge from submit-queue.

docker_upgrade_check: skip repoquery calls on containerized setups

Fedora/CentOS Atomic hosts don't have repoquery installed - also there
is no need to check available Docker rpms in the repos for Atomic

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527256


Note, that this solution is pretty naive - a better idea would be splitting
the playbooks for rpm and containerized installs for clarity

Automatic merge from submit-queue.

container-engine: move registry_auth.yml before pull

so that the atomic pull takes into account the credentials if
required.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Variables that are specifically booleans should be
cast to bool.  This is because users may sometimes
pass them as string values.  This is particularly
prevalent when using ini-style inventories.

Affected-by: https://github.com/ansible/ansible/issues/34591

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1531592

so that the atomic pull takes into account the credentials if
required.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Migrate to import_role for static role inclusion

In Ansible 2.2, the include_role directive came into existence as
a Tech Preview. It is still a Tech Preview through Ansible 2.4
(and in current devel branch), but with a noteable change. The
default behavior switched from static: true to static: false
because that functionality moved to the newly introduced
import_role directive (in order to stay consistent with include*
being dynamic in nature and `import* being static in nature).

The dynamic include is considerably more memory intensive as it will
dynamically create a role import for every host in the inventory
list to be used. (Also worth noting, there is at the time of this
writing an object allocation inefficiency in the dynamic include
that can in certain situations amplify this effect considerably)

This change is meant to mitigate the pressure on memory for the
Ansible control host.

We need to evaluate where it makes sense to dynamically include roles
and revert back to dynamic inclusion if and where it makes sense to do
so.

Fedora/CentOS Atomic hosts don't have repoquery installed - also there
is no need to check available Docker rpms in the repos for Atomic